Closed gokceneraslan closed 8 years ago
Hi Gökçen,
Thanks for the contribution! I've merged your pull request. If you think there is a better way to output information in a more readable manner, please feel free to implement and make another pull request! I'd love to see the improvement.
Thanks again for the help.
Best, Jean
I was also planning to add a new argument to scde.error.models
so that it can also return crossfit models, as well as the individual models. Something like:
scde.error.models <- function(counts, groups = NULL, min.nonfailed = 3, ..., return.crossfit=FALSE) {
...
if (return.crossfit) {
return(list(crossfit=cfm, individual=ifm))
} else {
rm(cfm)
return(ifm)
}
Then the users can visualize and do other stuff using crossfit models... Also, since it is FALSE by default, it does not change the default behaviour. What do you think?
Ah, I see. That sounds like a reasonable option to add. If you find the crossfit models useful, I'm sure others are also thinking the same thing :+1:
Other than visualizing, are there any other uses you're interested in for the crossfit models?
scde.error.models
function should propagate verbosity to other functions such ascalculate.crossfit.models
. Actually for the readability purposes, it would be better to split arguments into multiple lines and to align them.