Allow for passing slice type

keller-mark commented 12 months ago

Background

ZarrJS cannot currently be tree-shaken-out of the ZarrPixelSource class because it imports slice and BoundsCheckError.

Change List

Create an internal parent class which takes a slice function and error type as constructor parameters. Use super() in the subclasses to enable super(zarr.slice, zarr.BoundsCheckError) and super(zarrita.slice, zarrita.BoundsCheckError)
- @manzt is there a Zarrita equivalent of ZarrJS BoundsCheckError?

Checklist

[ ] Update JSdoc types if there is any API change.
[ ] Make sure Avivator works as expected with your change.

manzt commented 11 months ago

The slice helpers are just simple objects in both Zarrita and ZarrJS (or at least now they are: https://github.com/manzt/zarrita.js/pull/121). We can just create these ourselves, rather than using those utilities.

For the bounds check error, we can just create that ourselves as well (just make sure the slices are within the bounds) and then throw our own errors that we catch in the onTileError. See #700

manzt commented 11 months ago

Do you mind if I close in favor of #700 ?

keller-mark commented 11 months ago

No, go ahead!

hms-dbmi / viv