search

hms-dbmi / viv

Library for multiscale visualization of high-resolution multiplexed bioimaging data on the web. Directly renders Zarr and OME-TIFF.
http://avivator.gehlenborglab.org
MIT License
283 stars 46 forks source link

chore: Remove gl devDependency #829

Closed manzt closed 3 weeks ago

manzt commented 3 weeks ago

I'd assumed that this dependency was somehow used in our test suite to mock WebGL but it doesn't appear like removing it causes any problems to CI or running tests locally. I say we remove it.

See:

cc: @xinaesthete

xinaesthete commented 3 weeks ago

I think the tests effectively inherit from how luma.gl does its tests? I haven't looked into that in depth but seem to remember seeing puppeteer mentioned in some logs as I glanced over - so it may be that earlier versions of your tests used gl more directly but now hopefully WebGPU when it's used would also be covered without any particular changes to viv.

Anything that did use gl would be more surface area to consider as that kind of refactoring happened, so I think you want to be explicitly aware of whether it's actually doing anything useful and removing seems good.

ilan-gold commented 3 weeks ago

I think the tests effectively inherit from how luma.gl does its tests? I haven't looked into that in depth but seem to remember seeing puppeteer mentioned in some logs as I glanced over - so it may be that earlier versions of your tests used gl more directly but now hopefully WebGPU when it's used would also be covered without any particular changes to viv.

This would have been my assessment as well. If nothing breaks, I'd say it's fine to remove.