Ignition 8 Connector v2 - PR 5

hms-networks / IgnitionEwonConnector

Synchronize Ewon data to Ignition's Tag Historian

Apache License 2.0

10 stars 1 forks source link

Ignition 8 Connector v2 - PR 5 #140

Closed alexjhawk closed 1 year ago

alexjhawk commented 1 year ago

I misnumbered the last PR as No.3 when it should've been No.4, so this PR is No.5.

I've updated the previously mentioned PR timeline below:

This PR No. 4 5 - Last significant PR, containing documentation and additional source code changes
Next PR No. 5 6 - Small follow-up pull request to perform code signing and official release.
Next PR No. 5a 6a - Just prior to v2 release (or after, depending on time constraints), a patch should be performed to finalize the Ewon rebranding efforts.
- Most references to the eWon text have been changed to Ewon (proper, updated branding capitalization)
- Some instances of eWon remain, such as the module folder names, which can't easily be changed during an active development cycle (makes Git usage significantly more complex due to files changing also being renamed and/or moved.)
- Add: I think this can be done before the release of v2, and within PR 6. There is not much effort involved, most just testing afterward to ensure compile/run is ok.

alexjhawk commented 1 year ago

I misnumbered the last PR as No.3 when it should've been No.4, so this PR is No.5.

I've updated the previously mentioned PR timeline below:

This PR No. 4 5 - Last significant PR, containing documentation and additional source code changes
Next PR No. 5 6 - Small follow-up pull request to perform code signing and official release.
Next PR No. 5a 6a - Just prior to v2 release (or after, depending on time constraints), a patch should be performed to finalize the Ewon rebranding efforts.
- Most references to the eWon text have been changed to Ewon (proper, updated branding capitalization)
- Some instances of eWon remain, such as the module folder names, which can't easily be changed during an active development cycle (makes Git usage significantly more complex due to files changing also being renamed and/or moved.)
- Add: I think this can be done before the release of v2, and within PR 6. There is not much effort involved, most just testing afterward to ensure compile/run is ok.

alexjhawk commented 1 year ago

Also, I imagine it's very possible that this PR will quickly grow in size during the review. To make things more manageable, if something has been resolved to your satisfaction, please feel free to 'Resolve conversation'. This will make the PR much easier to follow and hopefully ensure nothing gets buried or missed.

alexjhawk commented 1 year ago

@it-hms @TomKimsey Apologies for another ping.

I meant to include the documentation link originally, but they are visible at https://hms-networks.github.io/IgnitionEwonConnector/.

it-hms commented 1 year ago

I did not get a chance to fully review. I did not see any errors or anything that would require changes, but I did have some questions about should the code exit in some places.

TomKimsey commented 1 year ago

Still reviewing, this is not forgotten.