search

hms-networks / IgnitionEwonConnector

Synchronize Ewon data to Ignition's Tag Historian
Apache License 2.0
10 stars 1 forks source link

Added check for and log of invalid tag name 8.0 #66

Closed alexjhawk closed 5 years ago

alexjhawk commented 5 years ago

Added a check for invalid tag names, and outputs to log any invalid tag names, with their full path, and an explanation of invalid tag name.

fixes #60

alexjhawk commented 5 years ago

Im wondering if there should be two regexs, one thats check if(replaceUnderscore) and one that is checked if(!replaceUnderscore). That way you can test if its valid and even say "hey your tag names have underscores but thats not valid in ignition unless you check the box in settings"

Ok, I'll add the second regex and check. Does the regex I have now look like it works for this particular case?

TomKimsey commented 5 years ago

names

Im wondering if there should be two regexs, one thats check if(replaceUnderscore) and one that is checked if(!replaceUnderscore). That way you can test if its valid and even say "hey your tag names have underscores but thats not valid in ignition unless you check the box in settings"

Ok, I'll add the second regex and check. Does the regex I have now look like it works for this particular case?

II think so, then in the other case you will want to make sure you allow periods but not underscores.

alexjhawk commented 5 years ago

names

Im wondering if there should be two regexs, one thats check if(replaceUnderscore) and one that is checked if(!replaceUnderscore). That way you can test if its valid and even say "hey your tag names have underscores but thats not valid in ignition unless you check the box in settings"

Ok, I'll add the second regex and check. Does the regex I have now look like it works for this particular case?

II think so, then in the other case you will want to make sure you allow periods but not underscores.

Ok, this should be all set for review then. What's up here now has the regex allow for underscores but not periods or allows for periods, but not underscores.

TomKimsey commented 5 years ago

Looks good, I am going to leave in unapproved till I test this afternoon.

alexjhawk commented 5 years ago

Looks good, I am going to leave in unapproved till I test this afternoon.

Ok. The 7.9 version should be identical to this one.

TomKimsey commented 5 years ago

One question I have is, is there any indication from ignition when you go to create a tag with an invalid name. If so we should print an error there too. Just in case there is some undocumented case.

alexjhawk commented 5 years ago

One question I have is, is there any indication from ignition when you go to create a tag with an invalid name. If so we should print an error there too. Just in case there is some undocumented case.

I'm not sure I know what you mean, but I've just made some small tweaks and changes to both the 8.0 and 7.9 PRs that include fixing the regex and changing the log messages a bit.