search

hms-networks / flexy-canary-connector

Apache License 2.0
0 stars 0 forks source link

Connector Data Handling, Javadoc Fixes, IDE File Changes, and Payload Implementation #34

Closed alexjhawk closed 1 year ago

alexjhawk commented 1 year ago

@it-hms @oliver-walker-hms @TomKimsey Bump -- this is still pending review.

alexjhawk commented 1 year ago

Commits are a bit general and large. Try to ensure your commits are more tightly scoped. When you have a list of changes in the commit body its time to start thinking about breaking that commit up into multiple commits.

Example: Improved CanaryConnectorConfig.java should probably be 4 commits

Commits should have been split out to begin with, my bad. Some of these commits evolved over time, so they started smaller in scope and then grew as I needed to make changes. Additional commits should've been used instead of adding on.