hms-networks / sc-ewon-flexy-extensions-lib

A library of extensions to the functionality of the Ewon Flexy Java environment (Ewon ETK), created by the HMS Networks, MU Americas Solution Center.
Apache License 2.0
2 stars 3 forks source link

File Circularized Error results in data discarded #20

Closed it-hms closed 1 year ago

it-hms commented 2 years ago

This needs to be a retry. Historical time should not be advanced so that the request is retired. There needs to be a error count.

alexjhawk commented 2 years ago

@it-hms,

There was a missing circularized event check for the string historical data EBD call.

This could have resulted in the potential loss of data when:

  1. Regular historical data EBD was successful
  2. Then, string historical data EBD triggered a file circularized error (which was missed)
alexjhawk commented 2 years ago

A fix was applied as part of a rebase operation I needed to do to resolve another bug.

Now, if there is a file circularized event, both of the red highlighted (below) method calls will result in CircularizedFileException being thrown and the yellow highlighted (below) method call, which updates the time tracker, will not be reached. image

alexjhawk commented 1 year ago

@it-hms Was the resolution of this issue satisfactory?

it-hms commented 1 year ago

yeah

alexjhawk commented 1 year ago

The issue will be closed. Thank you for your report.