hmsonline / cassandra-triggers

52 stars 13 forks source link

Pause for column family #2

Closed irieksts closed 12 years ago

boneill42 commented 12 years ago

Rock on. Reviewing now.


Brian O'Neill Lead Architect, Software Development Health Market Science | 2700 Horizon Drive | King of Prussia, PA 19406 p: 215.588.6024blog: http://weblogs.java.net/blog/boneill42/ blog: http://brianoneill.blogspot.com/

On 2/9/12 3:22 PM, "Isaac Rieksts" <reply+i-3162957-bdad5328a209990f48d97006a977517e64a2d65f-897229@reply.gith ub.com> wrote:

You can merge this Pull Request by running:

git pull https://github.com/irieksts/cassandra-triggers master

Or you can view, comment on it, or merge it online at:

https://github.com/hmsonline/cassandra-triggers/pull/2

-- Commit Summary --

  • Adding pause for a column family.

-- File Changes --

A src/main/java/com/hmsonline/cassandra/triggers/PausedTrigger.java (18) M src/main/java/com/hmsonline/cassandra/triggers/TriggerStore.java (19) M src/main/java/com/hmsonline/cassandra/triggers/TriggerTask.java (41)

-- Patch Links --

https://github.com/hmsonline/cassandra-triggers/pull/2.patch https://github.com/hmsonline/cassandra-triggers/pull/2.diff


Reply to this email directly or view it on GitHub: https://github.com/hmsonline/cassandra-triggers/pull/2

boneill42 commented 12 years ago

Hey...

This looks like you can pause a trigger, but when I re-enable the trigger will it process the transactions it missed while paused?

I was thinking more along the lines of pausing triggers for a whole column family. Then, the log entries would remain until processing for that column family was re-enabled at which time all the triggers would "catch back up" with the transactions they missed.

-brian


Brian O'Neill Lead Architect, Software Development Health Market Science | 2700 Horizon Drive | King of Prussia, PA 19406 p: 215.588.6024blog: http://weblogs.java.net/blog/boneill42/ blog: http://brianoneill.blogspot.com/

On 2/9/12 3:22 PM, "Isaac Rieksts" <reply+i-3162957-bdad5328a209990f48d97006a977517e64a2d65f-897229@reply.gith ub.com> wrote:

You can merge this Pull Request by running:

git pull https://github.com/irieksts/cassandra-triggers master

Or you can view, comment on it, or merge it online at:

https://github.com/hmsonline/cassandra-triggers/pull/2

-- Commit Summary --

  • Adding pause for a column family.

-- File Changes --

A src/main/java/com/hmsonline/cassandra/triggers/PausedTrigger.java (18) M src/main/java/com/hmsonline/cassandra/triggers/TriggerStore.java (19) M src/main/java/com/hmsonline/cassandra/triggers/TriggerTask.java (41)

-- Patch Links --

https://github.com/hmsonline/cassandra-triggers/pull/2.patch https://github.com/hmsonline/cassandra-triggers/pull/2.diff


Reply to this email directly or view it on GitHub: https://github.com/hmsonline/cassandra-triggers/pull/2

irieksts commented 12 years ago

Yes, it leaves the messages on the commit log until the trigger is re-enabled.

boneill42 commented 12 years ago

perfect.

On Thu, Feb 9, 2012 at 4:48 PM, Isaac Rieksts < reply@reply.github.com

wrote:

Yes, it leaves the messages on the commit log until the trigger is re-enabled.


Reply to this email directly or view it on GitHub: https://github.com/hmsonline/cassandra-triggers/pull/2#issuecomment-3896377

Brian ONeill Lead Architect, Health Market Science (http://healthmarketscience.com) mobile:215.588.6024 blog: http://weblogs.java.net/blog/boneill42/ blog: http://brianoneill.blogspot.com/