search

hmsonline / storm-cassandra-cql

Storm Cassandra Bridge built on CQL
Apache License 2.0
43 stars 38 forks source link

is CassandraCqlState leaking statments? #37

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hello,

We are seeing degradation on performance with time. So we are believing we have a leak somewhere. Should not we have some sort of reset of the this.statements field in the end of the commit method :

https://github.com/hmsonline/storm-cassandra-cql/blob/master/src/main/java/com/hmsonline/trident/cql/CassandraCqlState.java#L56

this.statements.clear();
ghost commented 9 years ago

After some tests, the leak is solved!

boneill42 commented 9 years ago

Great to hear Lucas, and fantastic catch. Thanks for the feedback.

leerobert commented 9 years ago

Nice catch!

ghost commented 9 years ago

Thx !

On Tue, Feb 3, 2015 at 7:58 PM, boneill42 notifications@github.com wrote:

Great to hear Lucas, and fantastic catch. Thanks for the feedback.

— Reply to this email directly or view it on GitHub https://github.com/hmsonline/storm-cassandra-cql/issues/37#issuecomment-72711585 .