search

hmsonline / storm-cassandra

Storm Cassandra Integration
Apache License 2.0
180 stars 90 forks source link

Expose astyanax config to storm #14

Closed ericdf closed 11 years ago

ericdf commented 11 years ago

I've patched the client interface and implementation so that the stormConf object is made available. This lets the stormConf carry additional settings for Astyanax. I've replicated your current settings as defaults.

One limitation still remains: there's only one set of values for all bolts in a topology. If someone needs to write to different cassandra clusters, that could present a problem.

ptgoetz commented 11 years ago

Hi Eric,

Thanks for the contribution.

A strange thing happened... a relatively sleepy project got 2 pull requests in the same day. ;)

Anyway, I merged the first PR, and it caused conflicts with your PR. Any chance you could update and fix that?

My appologies, I'm just a little short on time.

Thanks again,

Taylor

ericdf commented 11 years ago

Hi Taylor,

I'm glad you accepted the counter column PR as I'd like to use that as well. I've resolved the conflicts per your request. It was just import foo.

Eric

ptgoetz commented 11 years ago

Thanks Eric.

I merged this into the 0.3.x branch and master. Master is undergoing a lot of changes for 0.4.x, and I haven't pushed those yet.

I'll do a 0.3.1 release so your changes will be available via maven central.

Thanks again,

Taylor