search

hmsonline / storm-cassandra

Storm Cassandra Integration
Apache License 2.0
180 stars 90 forks source link

Storm cassandra connection pool sharing #32

Closed jamestyack closed 10 years ago

jamestyack commented 10 years ago

New AstyanaxClient factory that creates a single instance per Cassandra cluster. Previously, instances were being created on every makeState call to CassandraStateFactory.

The code has been re-factored slightly to make it clear that the previously named 'configKey' represents a C* cluster identifier.

irieksts commented 10 years ago

Looks good

ptgoetz commented 10 years ago

+1, but it should also be applied to the functions as well.

jamestyack commented 10 years ago

I'll take a look Taylor (I noticed that the examples weren't compiling when I checked out locally, which eventually led me back to a conflict with DefaultTupleMapper signature and out of sync POM reference to 0.4.0-SNAPSHOT). BTW, we may try to add an additional example that makes use of the newer classes in this repo/Trident.