search

hmvictor / radar-netbeans

A SonarQube plugin for Netbeans
Other
33 stars 22 forks source link

Re-factored for Sonar 5.3 #40

Closed rhendriks closed 7 years ago

rhendriks commented 8 years ago
hmvictor commented 8 years ago

Hi, rhendriks.

First, I want to thank you for the effort on the refactoring you made. I really appreciate the interest and the contribution.

Second, at this right moment a main goal of the plugin is compatibility, al least with the versions that are supported officially from SonarQube. (SonarQube 4.5.6 as read in the page today) so I'm really very sorry for not accepting your pull request. And yes, reviewing your refactored code I'm feel so ashame because my code is not so clean. I had to put some ifs block and that's not a very good design decision. So I have to think cleaner solutions to isolate specific configuration per version. And of course I'm open to suggestions.

So, again, my apologies and many many thanks for your time and effort. You are already contributing by pointing to the fact that code needs improvements in version handling.

Saludos y gracias.

dcebotarenco commented 8 years ago

Since SonarQube 5.3 is official version, you words makes me confused "al least with the versions that are supported officially from SonarQube." . I think the fix should be applied. I do agree that the fix should be backward compatible, but again if the main goal is to support all versions then i hope soon we will get a compatibility with 5.3 based on re factored proposed solution.