search

hmvictor / radar-netbeans

A SonarQube plugin for Netbeans
Other
33 stars 22 forks source link

Dependency updates for Radar 2.6 #45

Closed mdovey closed 8 years ago

mdovey commented 8 years ago

This is really just a update to the pom.xml to bring some of the dependencies up to date. Namely

netbeans.api.version 80 -> 802 sonar-runner-api 2.3 -> 2.4 maven-model 3.1.0 -> 3.3.9 jUnit 4.10 -> 4.12 gson 2.2.4 -> 2.6.2 mokito-core 1.9.5 -> 1.10.19 maven-core 3.1.0 -> 3.3.9 httpclient 4.5.1 -> 4.5.2 commons-codec 1.9 -> 1.10

The main piece of work, which I've put in a separate commit (in case of concerns of the above updates causing regression issues), is to update sonar-ws-client from 3.7.4 to 4.3.3

This requires a few code changes as org.sonar.wsclient.issue.Issue has a few new abstract methods.

4.3.3 was the most recent version of sonar-ws-client I could get to before hitting some blockers which would involve more substantial rewriting.

Beyond 4.3.3 org.sonar.wsclient.services.Rule becomes org.sonar.wsclient.rule.Rule and Rule.getKey() is now Rule.key(), Rule.getTitle() is now Rule.title and Rule.getDescription() is Rule.description(). However, there appear to be no longer any equivalent to setKey, setTitle or setDescription for Rule - it looks like these are set via a map in the constructor.

hmvictor commented 8 years ago

Hi @mdovey This seems a very interesting change. So let me make some reviews and tests and I will response your request as soon as I can.

Thank you and have a nice day.

hmvictor commented 8 years ago

Hi, @mdovey I have just reviewed your changes and I've accepted your pull request.

So many thanks for your contributions to Radar-Netbeans.