hmxmilohax / rock-band-3-deluxe

QoL enhancements and additions to Rock Band 3
https://rb3dx.milohax.org/
192 stars 70 forks source link

Pro Keys Trainer (learn an instrument) crashes if it is the first thing entered in a session. Works if qp game is entered first #471

Closed clwalker85 closed 7 months ago

clwalker85 commented 11 months ago

I was able to reproduce an issue similar to the recently fixed pro guitar trainer bug with the pro keys trainer, where the trainer would crash upon the first missed key. RPCS3 would show an error log of "Access violation reading location". I would not get the error if quick play is used first. I didn't notice any of the other problems in the screenshot for the pro guitar bug.

I recently set this up with the latest version of RPCS3 and RB3DX, with the Quick Configuration recommended settings from the RB3-PC Github README applied. I was also playing with a Wii MIDI Adapter (with the jumper resistor pulled off to imitate a PS3 adapter instead) and a Wii keyboard hooked up to the MIDI input, if it matters.

jnackmclain commented 10 months ago

fixed on develop branch with e86581b

jnackmclain commented 10 months ago

actually i should say i think i did

clwalker85 commented 9 months ago

Tested with the develop beta build and got the same error, except this time the error occurs before I can even begin any tutorial:

F {PPU[0x1000000] Thread (main_thread) [0x008f30b0]} VM: Access violation reading location 0x8 (unmapped memory)

Installing the latest stable build reverts it back to erroring on the first missed note in any tutorial.

jnackmclain commented 7 months ago

this was fixed at some point

clwalker85 commented 4 months ago

This appears to be somewhat fixed, it doesn't freeze on the first missed key. However, I can still reproduce a very similar issue after a couple of lessons. Instead of freezing, the track plays catch up and sometimes has the same track playing on top of itself. It makes it impossible to complete most trainings. See these videos for examples:

https://drive.google.com/file/d/1nmyxfjwvPNeXy3KJ5lZRxKEvRU5n6KLy/view?usp=sharing

https://drive.google.com/file/d/1niW9s8JZBLK_7Bwp7Po8OfHxK1_m6zvh/view?usp=sharing