hmxmilohax / rock-band-3-deluxe

QoL enhancements and additions to Rock Band 3
https://rb3dx.milohax.org/
177 stars 64 forks source link

Sustains that are too long at the end of the song and go into the fade out can lock the end game feedback box in place #720

Open Radekore opened 3 weeks ago

Radekore commented 3 weeks ago

Describe the bug Kind of the fault of a not-so-great custom honestly but if a sustain goes so long that it doesn't actually cut off properly by the end of the song the end screen will keep the feedback box on screen and it won't disappear on the results screen.

In this case the song was the RhythmVerse custom of Renegade by Paramore, also seems to have been dependent on video calibration settings pushing the sustain tail back even later - the glitch happened on my first run at -115 ms but by using -69 ms to push the sustain tail forward by a few frames it worked as normal.

To Reproduce Steps to reproduce the behavior:

  1. Play a song that has a poorly managed final sustain (at low enough delay to push the sustain tail backwards into the fade out)
  2. See feedback box not disappear - it actually flashed a few times after the song and even showed a "2" briefly but then stayed in place as FC

Expected behavior Feedback box goes away once final results screen shows up, or at least after a reasonable amount of time has passed

Screenshots

https://github.com/hmxmilohax/rock-band-3-deluxe/assets/143662734/341e83d5-5dc8-4b59-b028-4abe03a1783a

vlcsnap-2024-06-08-00h50m15s574

Game Information