search

hnakamur / FormatLink-Firefox

A Firefox web-extension to copy the URL and the title or the selected text to clipboard
https://addons.mozilla.org/ja/firefox/addon/format-link3/
MIT License
45 stars 8 forks source link

keyboard short-cut of the manifest.json #29

Closed miz999 closed 2 years ago

miz999 commented 5 years ago

An error is given at the time of installation in waterfox 56.2.13 . format of the keyboard short-cut of the manifest.json did not seem to support

hnakamur commented 4 years ago

Sorry for being late. And thanks for sending a pull request. For the first commit, I've merged another pull request https://github.com/hnakamur/FormatLink-Firefox/pull/32 For the second commit, I think the order of modifiers doesn't matter: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands When I use the keyboard shortcut settings, the modifiers order is like Shift + Alt +C (Shift first, Alt second), so I keep it this way. For the third comment, please don't put binary in source repository.

Could you upgrade to the latest version 4.0.2 and check to see the problem is solved? Thanks!