ignore 'text' variable when no text is selected

[atomGit]

i thought the default behavior was to ignore the text variable when no text is selected, however this is not working

page title: something pattern: {{title}}{{text}}

produces 'somethingsomething'

[hnakamur]

Sorry, the document was wrong. I just fixed it at https://github.com/hnakamur/FormatLink-Firefox/commit/c5cba5d932db43dbf719858fcbbfd78437afd641.

[atomGit]

thank you, but i was hoping for a different approach - i think it it would be better, and more intuitive for users, if the text variable were simply ignored if there was no text highlighted

[hnakamur]

I need text variable as is. How about adding selected_text variable?

[atomGit]

sure - that would work

i don't understand though; the selected_text var would work exactly the same as text, no? so i'm wondering why you'd need a new variable

[hnakamur]

text variable value is not the same as selected_text since page title value is used if no text is selected.

text variable value is:

• the selected text if some text is selected,
• the link text if you open the context menu over a link,
• the page title otherwise.

[atomGit]

ah, i see

by the way, THANKS for continuing to work on this - it's a very useful extension!

[hnakamur]

Thanks for kind words. I will merge Add selected_text variable (fixes #48) by hnakamur · Pull Request #53 · hnakamur/FormatLink-Firefox now.

[hnakamur]

I submitted version 5.3.0 to https://addons.mozilla.org/ja/firefox/addon/format-link3/