search

hnakamur / go-scp

[Unmaintained] A scp client library written in Go
MIT License
41 stars 23 forks source link

invalid memory address panic #11

Closed fugr closed 5 years ago

fugr commented 6 years ago

runtime error:invalid memory address panic or nil pointer dereference

github.com/hnakamur/go-scp.(*SCP).SendDir.func1.2(0xc4202886c0,0x18,0x0,0x0,0xc41ac0,0xc42036b3e0,0x0,0x0) $GOPATH/src/github.com/hnakamur/go-scp/source.go:106 +0x66

panic reference https://github.com/hnakamur/go-scp/blob/master/source.go#L106

myWalkFn := func(path string, info os.FileInfo, err error) error

It's oddly，info is nil and err is non-nil?

hnakamur commented 5 years ago

Sorry for being late. Could you send pull request from your fixing commit https://github.com/fugr/go-scp/commit/6e3a8325e59af950e23429b733224d310dd18823?

Actually I created https://github.com/hnakamur/go-scp/pull/14 before noticing your commit, but I think it's better to use your commit.

fugr commented 5 years ago

your commit is OK

hnakamur commented 5 years ago

I merged https://github.com/hnakamur/go-scp/pull/14 Thanks!