hnasr / javascript_playground

Javascript playground tutorials
1.06k stars 948 forks source link

Base64 may not be URL safe #26

Open Rohitrajak1807 opened 3 years ago

Rohitrajak1807 commented 3 years ago

https://github.com/hnasr/javascript_playground/blob/bc01f3c07fef893ceefd465fb32b655b36b1b214/sharding/index.js#L65

@hnasr base64 encoding used in the URL shortener may have a '/' un the URL_ID, so using digest('base64url') is advised to avoid this.