search

hnccbits / contest.hnccbits.com

HnCC Contest Page: Upcoming Contests, Leaderboard, Editorial
GNU General Public License v3.0
1 stars 17 forks source link

#26 Fixed toggling of buttons problem #33

Closed rt1301 closed 4 years ago

rt1301 commented 4 years ago

A solution to the toggling buttons problem. I have changed the handleExpandClick option so that only the clicked card's content are visible

suraj-sloth commented 4 years ago

This PR fails the netlify deploy checks. Please pull the latest changes and commit on this PR/ create a new one. Also attach images/gif related to this patch.

rt1301 commented 4 years ago

Can you provide the permission to check the logs of Netlify so that I can check what errors are occurring?

suraj-sloth commented 4 years ago

The issue regarding the netlify deploy checks is solved. Just pull the respective changes and commit to this PR :)

rt1301 commented 4 years ago

So, should I make the PR once again? coz here it still shows that the checks have failed

rt1301 commented 4 years ago

How is the netlify deploy checks error are corrected?

suraj-sloth commented 4 years ago

@rt1301 Yes please proceed with another PR. Netlify deploy checks will fail if you have any warnings in your local build.

rt1301 commented 4 years ago

Hey, I rectified the Netifly Deploy errors

suraj-sloth commented 4 years ago

Hey, this is the deploy preview of your PR https://deploy-preview-33--hncc-contest.netlify.app/.It seems that the problem isn't resolved yet. It would be great if the clicked card only expands, not the the others.

rt1301 commented 4 years ago

I tried fixing that error, by using a Accordian as well as changing the onClick function. Both are giving this same result. This is some issue related to the the material UI react library