hnes / libaco

A blazing fast and lightweight C asymmetric coroutine library 💎 ⛅🚀⛅🌞
https://libaco.org
Apache License 2.0
3.5k stars 391 forks source link

reserved identifier violation #1

Closed elfring closed 6 years ago

elfring commented 6 years ago

I would like to point out that an identifier like “_ACO_Hdoes eventually not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

hnes commented 6 years ago

Thank you very much, Markus, @elfring.

It is very kind of you to point out this mistake. I'll fix that immediately.

hnes commented 6 years ago

This fix absolutely deserves the new patch release v1.2.1 .

hnes commented 6 years ago

The release of v1.2.1 had already fixed such noncompliant definition of the macro name problem.

Thanks Markus for your report :D

elfring commented 6 years ago

Thanks for your small source code improvement.

I suggest to reconsider also an identifier like “aco_s__”.

hnes commented 6 years ago

And also, the "__xmm*" identifiers have the same problem too. Thanks Markus :D

I'll fix them as soon as possible.

elfring commented 6 years ago

Will these source code adjustments have got any influence on the definition for an identifier like “ACO_VERSION_PATCH”?

hnes commented 6 years ago

Yep... Bingo! Thank you very much, Markus.

hnes commented 6 years ago

Solved in the release of v1.2.2.