hneth
commented
6 years ago Hi Nico,
sounds good to me — so yes, please implement this change.
Actually, I just spotted a related parameter issue: The “round” is currently not passed on to plot_tree() and plot_fnet(). Does this fix this issue in the same process? If so, even better.
Best, Hans
On 15 Feb 2018, at 17:38, ngradwohl notifications@github.com wrote:
I just tried out the dot syntax (...) on the plot.riskyr function and it turned out to be fairly easy. It appears way more elegant this way, as defaults are retained by ... default.
It throws some exceptions (e.g., for the plot_tree) as no dots are included there. But I don't even find this problematic, as one is told which parameter is unused. Should I add the dots to the remaining plotting functions?
If you approve, I will delete the parts I just commented out.
You can view, comment on, or merge this pull request online at:
https://github.com/hneth/riskyr/pull/14
Commit Summary
• added missing fullstop • Merge remote-tracking branch 'upstream/master' • added test for using the dots • added dot syntax (...) to plot.riskyr File Changes
• M R/riskyr_class.R (183) Patch Links:
• https://github.com/hneth/riskyr/pull/14.patch • https://github.com/hneth/riskyr/pull/14.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
I just tried out the dot syntax (...) on the plot.riskyr function and it turned out to be fairly easy. It appears way more elegant this way, as defaults are retained by ... default.
It throws some exceptions (e.g., for the plot_tree) as no dots are included there. But I don't even find this problematic, as one is told which parameter is unused. Should I add the dots to the remaining plotting functions?
If you approve, I will delete the parts I just commented out.