hngi / Team-Incredible-FE-Hotel-Bami

Hotel Website (Lead - bamiogunfemi)
https://hotel-bami.netlify.app
3 stars 7 forks source link

complete header section with CSS and JS files #17

Closed tosinibrahim96 closed 4 years ago

tosinibrahim96 commented 4 years ago

6

tosinibrahim96 commented 4 years ago

The purple circle beside home should indicate that it's the active page, so please fix that

Please can you show me an image so I can understand. When I view it here, it's active on the home tab

bamiogunfemi commented 4 years ago

The purple circle beside home should indicate that it's the active page, so please fix that

Please can you show me an image so I can understand. When I view it here, it's active on the home tab

image

tosinibrahim96 commented 4 years ago

Beautiful work guys @tosinibrahim96 and @delecoder

Might be nice if we can add some tiny things. I think our header need a higher z-index say z-index: 100, position: relative.

Then @media query 755 upwards, might be nice if nav-link width reduces so it's slightly far away from the logo

Thanks boss

This is what 755px looks like.

iobami

Please what do you mean when you say

nav-link width reduces so it's slightly far away from the logo

iobami commented 4 years ago

Please what do you mean when you say

nav-link width reduces so it's slightly far away from the logo

Okay, I'll edit and send a screenshot, you can also zoom in on the figma design.

Look at the space between BelleView and Home... Contact Us

We need to space the header that way

iobami commented 4 years ago

Suggestion, I think margin or padding space between home... Contact Us is too large.

iobami commented 4 years ago

hng-hotel-header1

tosinibrahim96 commented 4 years ago

hng-hotel-header1

This is the view on desktop screen and 755px is tablet. Are you saying this is how it should be viewed on tablet

Xemicolon commented 4 years ago

The spacing between the nav links seems much..