hngprojects / hng_boilerplate_csharp_web

https://api-csharp.boilerplate.hng.tech

Apache License 2.0

79 stars 42 forks source link

fix: fixes for invitations #317

Closed Ace2489 closed 1 month ago

Ace2489 commented 1 month ago

Description

This PR fixes a number of issues with invite links:

Improper logging of invitation requests.
Wrong invitation links generated for the unique organisation links.
Potential duplicate use of email invites.
Coupling of saved invites to the frontend url — fixed by only using the GUID invite code.

Changes proposed

What were you told to do?

Fix multiple issues with the invite links including:

Duplicate use of email invites.
Invalid links being generated by the application.
Coupling between the invites saved in the db and the FE url.

What did you do?

Made the email invites one-use.
Stripped the FE url from the db records.
Fixed the generated unique organisation link.
Corrected and removed duplicate application logs.
Created the backing methods, commands, and handlers to enable the above.

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.
[x] I am making a pull request against the dev branch (left side).
[x] My commit messages styles matches our requested structure.
[x] My code additions will fail neither code linting checks nor unit test.
[x] I am only making changes to files I was requested to.