hngprojects / hng_boilerplate_nextjs

https://deployment.nextjs.boilerplate.hng.tech

206 stars 265 forks source link

Fix: Fix Notifications list Margins with the submit button #1500

Closed seshto13 closed 2 months ago

seshto13 commented 2 months ago

Description

Increase the right margin or padding on the Notification Settings page to provide sufficient space between the UI elements and the edge of the screen.

Closes #1222 Issue Link : https://github.com/hngprojects/hng_boilerplate_nextjs/issues/1222

Changes proposed

What were you told to do?

Increase the right margin or padding on the Notification Settings page to provide sufficient space between the UI elements and the edge of the screen.

What did you do?

I fixed the right margin on the notification settings page to uniformly align and I made sure the consistence is across all screen sizes

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.
[x] I am making a pull request against the dev branch (left side).
[x] My commit messages styles matches our requested structure.
[x] My code additions will fail neither code linting checks nor unit test.
[x] I am only making changes to files I was requested to.

Screenshots/Videos

Screen Shot 2024-08-24 at 4 07 49 PM

Screen Shot 2024-08-24 at 4 08 38 PM

Screen Shot 2024-08-24 at 4 08 54 PM

github-actions[bot] commented 2 months ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	14.5%	778 / 5365
🔵	Statements	14.17%	780 / 5501
🔵	Functions	14.02%	213 / 1519
🔵	Branches	9.84%	229 / 2325

File Coverage

No changed files found.

Generated in workflow #526