hngprojects / hng_boilerplate_php_laravel_web

Apache License 2.0
146 stars 58 forks source link

feat: retrieve all faqs for static page #469

Closed RaphAlemoh closed 2 months ago

RaphAlemoh commented 2 months ago

Description

This pull request implements Implement a new API endpoint that allows the authorised user to fetch frequently asked questions (FAQs) from the database. The endpoint should retrieve the FAQs, format the response in JSON, and implement appropriate error handling. ​

Related Issue (Link to Github issue)

Feature #216 ​ Endpoints GTE /api/v1/faqs

Enable retrieval of all faqs

How Has This Been Tested?

image

Screenshots (if appropriate - Postman, etc):

Types of changes

gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13348460](https://dashboard.gitguardian.com/workspace/575673/incidents/13348460) | Triggered | Generic High Entropy Secret | 02a1d99a2a058055b7eb75745e45bda35d7549b7 | .env.example | [View secret](https://github.com/hngprojects/hng_boilerplate_php_laravel_web/commit/02a1d99a2a058055b7eb75745e45bda35d7549b7#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cR61) | | [13348444](https://dashboard.gitguardian.com/workspace/575673/incidents/13348444) | Triggered | Generic Password | 02a1d99a2a058055b7eb75745e45bda35d7549b7 | tests/Feature/RoleCreationTest.php | [View secret](https://github.com/hngprojects/hng_boilerplate_php_laravel_web/commit/02a1d99a2a058055b7eb75745e45bda35d7549b7#diff-9861a81de5bdc300c7b8dce5bb01e95d8f79ec2e12a7fb4d0de96063ccf5ac89R25) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.