hngprojects / hng_boilerplate_python_fastapi_web

Apache License 2.0
154 stars 137 forks source link

enhancement: update billing plan endpoints docs to show sample return data #944

Closed chimeziriobioha closed 3 weeks ago

chimeziriobioha commented 3 weeks ago

Description

Update billing plan endpoints docs to show samples of expected data so frontend developers can easily integrate with the backend. Endpoint docs updated include:

Related Issue

[FIX]: Add Expected Data Samples To Docs For All Billing Plan Endpoints #941

Motivation and Context

Frontend developers and others viewing the backend docs should be able to know exactly what to expect from each endpoint.

How Has This Been Tested?

Screenshots:

Before The Update

boilerplate get all billing plan return value boilerplate post billing plan return value

After The Update

updated billing plan schema all updated billing plan schema single

Types of changes

JoshuaOloton commented 3 weeks ago

This issue looks resolved already @traderstechie

chimeziriobioha commented 3 weeks ago

This issue looks resolved already @traderstechie

Not really @JoshuaOloton . My PR is not about the endpoint functionality, but the docs that shows what's returned in the data key, which tells frontend guys what to expect from the endpoint.

johnson-oragui commented 3 weeks ago

You might as well fix the rest of the docs if this qualifies as an issue.

chimeziriobioha commented 3 weeks ago

You might as well fix the rest of the docs if this qualifies as an issue.

I believe it's something that should be done. If not now, then later. Maybe this one will bring attention to it. Without good docs, it'll be hard for non-contributors to integrate the product. It doesn't particularly matter if it qualifies as an issue now or not.