hngprojects / hng_boilerplate_remix

130 stars 126 forks source link

fix: added left-0 to FooterCookieConsent component to ensure it start… #335

Closed KehindeDaniels closed 3 months ago

KehindeDaniels commented 3 months ago

[FEAT] External static page > Floating footer cookie consent component #28 https://github.com/hngprojects/hng_boilerplate_remix/issues/28

Changes proposed

What were you told to do?

Implement a floating footer cookie consent component

What did you do?

Added a left-0 class to the FooterCookieConsent component to ensure it starts from the left edge.
Ensured the component is responsive.
Utilized existing button components for design consistency.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.
[x] I am making a pull request against the dev branch (left side).
[x] My commit messages styles matches our requested structure.
[x] My code additions will fail neither code linting checks nor unit test.
[x] I am only making changes to files I was requested to.

Screenshots/Videos

Frame 1618873047

Video video 1-Test for footer cookie consent component

KehindeDaniels commented 3 months ago

My former pr was merged, but on test, i noticed the with of the footer cookie did not span the viewport width, so, I fixed it and created a new pr