search

hnhx / librex

Framework and javascript free privacy respecting meta search engine
GNU Affero General Public License v3.0
785 stars 92 forks source link

Better search redirection - final #245

Closed vdbhb59 closed 1 year ago

vdbhb59 commented 1 year ago

Final entry to make better search redirection.

amogusussy commented 1 year ago

You can make changes to Pull Requests after you've made them. You don't need to make a new PR for each change. If you don't know how to do this, got to your git repo, click the drop down menu that says "main", then click on whatever branch your original PR is in. Then, if you're making changes via github's uploading file options (assuming that's what you're doing), it'll all be in the same branch, so there's no need to make new PRs. Also, if you close the page, make sure to re-open the particular branch, since github will always put you in the main branch by default. If you're using it in the command line, run git push origin branch-name, where branch-name is whatever branch you're working in. Also, make sure to give your branches descriptive names, so you're able to remember what each branch is for, rather than patch-N.

vdbhb59 commented 1 year ago

I know that, and that is what I always do, but for some weird reason yesterday it did not do that. It kept making new patches, even when I went to a branch and I made changes. I have been doing PRs for quiet sometime now and was finding it frustrating. I only use browser for Git though.

I can delete all of those if you wish, but would instead request you to merge them for this time.

hnhx commented 1 year ago

Can you make this in 1 PR?...