Add CI - Githubissues

hnicke / jsonpatch.nim

4 stars 0 forks source link

Add CI #2

Open hnicke opened 3 years ago

hnicke commented 3 years ago

[x] Run tests
[x] Generate docs
[x] Check style
[ ] Lint (is there a nim linter?)

jayvdb commented 3 years ago

There is a github action which slurps up nim check output and converts it to errors. https://github.com/jiro4989/nimlint-action/blob/master/entrypoint.sh I've been looking for a way to make nim check return an exit code when a hint or warning is emitted, but it doesnt seem possible.

https://github.com/nim-dev/nimlint doesnt seem to emit a modified file.

https://github.com/alehander92/nim-linter/issues/1

https://github.com/FedericoCeratto/nimfmt/pull/2 seems to work, but doesnt emit warnings for problems found by nim check.