hnmr293 / sd-webui-cutoff

Cutoff - Cutting Off Prompt Effect
Other
1.2k stars 85 forks source link

Request to have the plugin compatible with wildcards #13

Open BJeannot1 opened 1 year ago

BJeannot1 commented 1 year ago

Hello, when using a wildcard with dynamic prompt (https://github.com/adieyal/sd-dynamic-prompts), assuming i have wild cards for colors named colors1 and colors2, the following prompt will generate random colors at generation time :

a cute girl, colors1shirt with colors2tie, colors1shoes, colors1hair, colors2eyes, colors2skirt 2

for example, it will generate this : a cute girl, white shirt with green tie, red shoes, blue hair, yellow eyes, pink skirt

i thought it would be cool if we could enter colors1 , colors2in the settings of the cutoff extension to make sure that any generated word for colors1 and colors2 is selected for the cutoff. What do you think ?

Anyway, thank you for your awesome and much needed extension. Best regards,

hnmr293 commented 1 year ago

Sorry, I don't use wildcard feature in dynamic prompt. I may implement it someday, but it is low priority. If you are familer with python, pull requests are welcome. Thank you!

pmcculler commented 10 months ago

I did some work in this area after forking the repo. First, in the fork, most of the time you don't have to specify color target words as those are discovered and made targets automatically. If you do want to specify a target token, you can do so inline in the prompt box with a special delimiter, currently &&. So your prompt would be "1girl, &&white&& shirt, &&blue&& shoes" etc. No need for a separate prompt box, which means Dynamic Prompts and such can get in on the action with this extension. The problem with going any further though is that I can't demonstrate that this extension fundamentally works. Experiments are showing it might be slightly better than not having it at all, but the difference is slight. Color bleed happens all over the place on any setting combination I could try. So, what's wrong with the extension? Why doesn't it work anymore? 🤔