search

hnordquist / INCC6

INCC6
4 stars 8 forks source link

DTC corrected doubles calc was wrong #140

Closed hnordquist closed 7 years ago

hnordquist commented 7 years ago

While writing tests for avg_sum, found an error in the doubles calculation.

hnordquist commented 7 years ago

Download new NCCCore.dll. Changed the doubles to use the background doubles (had been subtracting singles).

jflongo commented 7 years ago

Okay, good. I found an issue with the final pass outlier calculation on when you have both doubles and triples: if the doubles outlier test succeeds, the test should stop, but it if fails, triples are tested. Instead, after double succeeds, triples are still tested, with potentially different results. More details later