Open wasnotrice opened 4 years ago
Hi @wasnotrice , those are definitely changes I would include into the main project. It would be awesome if you could create PRs for the new features/fixes.
sorry, any ETA or smth for iOS support? :)
I do have iOS support working on a fork. I made a lot of changes that were intertwined, as I was making sure the library could do everything I needed it to do. I will try to detangle the changes and make PRs one-at-a-time :)
@wasnotrice maybe release it as "alpha" version? to help with testing? :))
@robmarti I've finally started breaking apart my promised changes :) I'm submitting a set of pull requests today that target web and android. There are also a couple more. Once all of these are resolved, I'll make a request that adds nearly full iOS support for the current feature set. I think descriptors are the only bit that isn't implemented yet.
The pull requests are logically separate, but they assume the changes from previous PRs exist.
/cc @Kepro
Hi @robmarti, I used your library as a starting point for integrating BLE into a capacitor project, knowing that I would need to add iOS support. I discovered a few more things I need in my project, and have been adding them as needed in my own branch.
How do you feel about rolling these changes back into the main project? I'd open proper PRs for each, if it makes sense. Otherwise, if not, I can just maintain a custom fork for my own purposes.
Here are the updates I've made (or am planning) on my fork:
Are these updates you would want to include?