ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
194 stars 79 forks source link

[BUG] can't download new data #1038

Closed akasolace closed 3 years ago

akasolace commented 3 years ago

Screenshot 1 Screenshot 2 Screenshot 3 error.log HO-2021-05-17.log

Originally posted by @poteus in https://github.com/akasolace/HO/issues/1021#issuecomment-842790553

akasolace commented 3 years ago

@poteus I created the bug ticket on your behalf, in my view this is a different issue than #1021 (@wsbrenk I think you agree) Could you please just confirms you also experience that issue from macOS. Also could you share your database here, thank you.

poteus commented 3 years ago

Confirmed, the bug only appears on my Windows box.

Which database do you need?

Screen Shot 2021-05-18 at 8 22 58 AM

tychobrailleur commented 3 years ago

Intriguing, that game ([matchid=20955045]) does not involve Team ID 27090, which would explain the error.

poteus commented 3 years ago

I thought the same thing. Then I thought that it could be a game that one of my player played before I purchased it... I have not check that yet tho.

poteus commented 3 years ago

Hum, probably not... The game was in 2004, between 2 bots.

tychobrailleur commented 3 years ago

Hum, probably not... The game was in 2004, between 2 bots.

I guess you could delete the game from the Matches list. :-)

poteus commented 3 years ago

I do not know how to do that tho...

akasolace commented 3 years ago

I can't check now but I notice this is an hto integrated game not a regular one .... what surprises me is that HO behave differently on Windows and on MacOS, you have the same database for both ? You can put here the zip file highlighted in your screenshot, I will try to have a look later today ...

poteus commented 3 years ago

2 different databases...

Windows database db_Starlite-2021-05-18.zip

IOS database db_Starlite-2021-05-19.zip

akasolace commented 3 years ago

indeed there is no such game in htointegrated system ...

akasolace commented 3 years ago

so there are 2 things:

  1. understand why your HO is trying to download a non-existing match
  2. ensure error 51 does not crash HO! (actually there is an error message but HO! does not crash)
akasolace commented 3 years ago

@poteus I have no idea where those ghost games are coming from.... I can't find trace of them in HT. In that case I think the simpler is to delete them manually as per the screenshot below (in match tab you select the game you want to delete and click on the red cross on the bottom) You might have to delete couple of them.

I created #1040 to facilitate such tasks in the future. Meanwhile I will close this ticket as it is not really a bug. The real bug was to get those entries in the first place but don't know how to investigate this.

image.

wsbrenk commented 3 years ago

@akasolace did you check if sourcesystem of those matches was hattrick? Maybe those matches were from the youth team?!

SourceSystem {

HATTRICK((int) 0),
YOUTH((int) 1),  // youth match
HTOINTEGRATED((int) 2); //integrated match
akasolace commented 3 years ago

@wsbrenk I did check it was not a youth match .... I have no idea where those entries came from ...

akasolace commented 3 years ago

I just experienced that bug (see #1038)

wsbrenk commented 3 years ago

match 20955045 from 2004 is not the correct SourceSystem=htointegrated but hattrick

i don't find this match in his match archive. could it be, that hattrick removes tournament matches from the archive?