search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
195 stars 79 forks source link

[BUG]Initial rating calculation does not take trainer type into account #1281

Closed wsbrenk closed 2 years ago

wsbrenk commented 2 years ago

when ho is started the lineup module does not show correct ratings if the trainer type is not a neutral one.

After changing this trainer type in the lineup simulator, the ratings are calculated correctly.

wsbrenk commented 2 years ago

matchorders downloads wrong coachModifier value (error in hattrick?)

wsbrenk commented 2 years ago

chpp ticket is created

wsbrenk commented 2 years ago

currently downloads are fine (StyleOfPlay=-10 for defensive trainer type)

wsbrenk commented 2 years ago

StyleOfPlay=0 again (since two days)

wsbrenk commented 2 years ago

answer from HTs:

This isn't a bug. The team hasn't set their match order and their default order is saved with 0 (neutral) and that's what the match simulation would have used if the team had a tactical assistant (or as close to neutral that's allowed based on their level). However, since they don't have a tactical assistant it's moved to the the coach's affinity when the actual match is played.

It has to be this way, because if we show -10 here just because the trainer has a defensive affinity and the user later hires a tactical assistant it would no longer be -10. That would really be considered a bug. It has to be up to the CHPP dev to handle this (read TacticalAssistantLevels from file=club).