ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
195 stars 79 forks source link

[eFEAT] error message instead exception when receive bad xml #140

Closed yaute74 closed 5 years ago

yaute74 commented 5 years ago

Following the problem encountered by A-P-O-C [post=17237535.243]: he get an exception when he try to download xml data from hattrick. He receive an html page due to network security firewalls. Instead of return an exception we must return an explicit error

akasolace commented 5 years ago

@yaute74 should I assign this one to you ?

yaute74 commented 5 years ago

I do some tests and I cannot display the html document of A-P-O-C with java swings (it's an html with java script)

So what I do it's to display this message:

Cannot parse xml data (you will have more informations in log file). The problem may come from your security policy.

And in the log I add the data that we receive:

13:16:49 [Error] core.file.xml.XMLManager: Cannot parse data:.....

It's a small modification and it will work for all data type.

@akasolace it's ok for you ?

akasolace commented 5 years ago

@yaute74 it sounds a good approach to me @brokenelevator @konved any second opinions ?

brokenelevator commented 5 years ago

no. I'll trust your judgement on this one.

akasolace commented 5 years ago

closed by ae121aa