ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
194 stars 79 forks source link

[FEATURE] National Team Prospects View & Lineup Bug Fix #1832

Open Achill-3s opened 1 year ago

Achill-3s commented 1 year ago

Is your feature request related to a problem? Please describe. As a National Coach, I can only see my selected lineup. It would be much more useful to be able to see the 150 NT Prospects which are selected into a different tab. image

Describe the solution you'd like Create new Tab called 'NT Prospects'. Display all selected Prospects in a similar way to the Tab 'Squad' Allow button to move Prospects from the 'NT Prospects' Tab to the 'Squad' Tab. This should also automatically update the Prospects in Hattrick side.

Additional context Also there is a bug where when you setup the lineup of the National Team and you try to upload your orders, it gives the error that you cannot do so, because it is not your own team. It shouldn't gives this error for the National Coach. image

wsbrenk commented 1 year ago

i will try to fix the match order bug first.

Concerning NT Prospects, i don't know if the required information can be accessed by the chpp api.

Achill-3s commented 1 year ago

Let me know if there is any way i can help you out, such as testing etc.

Also the prospects api, only the Hattrick developers will logically know. So i assume you have a way to contact them for the above or do you want me to try to reach out for them instead?

wsbrenk commented 1 year ago

this is from CHPP request list:

Important

wsbrenk commented 1 year ago

@Achill-3s newest beta changed the nt match order access. I can't test it by myself.

Achill-3s commented 1 year ago

@wsbrenk Still pulls an error, a different one this time. Seems like you have part of code trying to verify if the NT Teamid has me as the Owner ID, instead of the NT Coach.

My User ID is 13724902 and the NT TeamId is 3140 when you testing the code, since you most probably matching wrong fields there for your validation, as it's probably different to normal Teams where there is actual Owner and not a Coach ID.

HO Beta Version - HO-7.0.478.1-portable-win-BETA-JRE JRE Version - 17.0.3

java.lang.RuntimeException: CHPP Error - 59 - (59) Additional Info: The supplied teamId does not refer to a senior or youth team managed by the requesting user at core.net.MyConnector.uploadMatchOrder(MyConnector.java:359) at core.net.OnlineWorker.uploadMatchOrder(OnlineWorker.java:716) at module.lineup.lineup.MatchAndLineupSelectionPanel.uploadLineupToHT(MatchAndLineupSelectionPanel.java:369) at module.lineup.lineup.MatchAndLineupSelectionPanel.lambda$addListeners$1(MatchAndLineupSelectionPanel.java:194) at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972) at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2313) at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405) at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262) at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279) at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297) at java.desktop/java.awt.Component.processMouseEvent(Component.java:6626) at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3389) at java.desktop/java.awt.Component.processEvent(Component.java:6391) at java.desktop/java.awt.Container.processEvent(Container.java:2266) at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5001) at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324) at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833) at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4948) at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4575) at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4516) at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2310) at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780) at java.desktop/java.awt.Component.dispatchEvent(Component.java:4833) at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:722) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:716) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97) at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:746) at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:744) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:743) at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203) at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124) at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

image

image

HO-1679176985.log

Achill-3s commented 1 year ago

Hello [wsbrenk], NT Match Order Issue still persists.

Attaching the file you have requested. Also check your HT-Mail ingame for info for it.

image cynt.zip

wsbrenk commented 1 year ago

It looks like the match orders for NT Teams is not supported by CHPP. Download did not work today.

Achill-3s commented 1 year ago

Please find updated file. cynt2.zip

wsbrenk commented 1 year ago

download of nt prospects is on the chpp feature request list (not available yet in ht).

what could be done in next HO version: add a feature to import tracker hrfs to an extra prospect panel