search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
194 stars 79 forks source link

refactor: separation of translation functionality into the Translation class #2108

Closed sgcr closed 3 months ago

sgcr commented 4 months ago

  1. changes proposed in this pull request:

    • separation of translation functionality with the new Translator class: added constants that were used at several places
    • moved the translations files from the sub-directory 'sprache' to 'language' because it means language
    • renamed the language 'Deutsch.properties' to 'German.properties' corresponding to all other language files that are named in english

  2. src/main/resources/release_notes.md ...

    • [x] does not require update
sgcr commented 4 months ago

Thanks :)

Yes, of course. Will be added for compatibility.

sgcr commented 4 months ago

Still not finished due to other findings of my change.

sgcr commented 4 months ago

UserParameter reads the legacy language now and converts it.

Ready to merge from my side.

Should I always squash the commits or is there an option for you?

@wsbrenk