[FEATURE] RMA index

[mastertnt]

Is your feature request related to a problem? Please describe. As a user I want to have the RMA (rate-my-academy) skill index in the youth tab in order to have a comprehensive value to select my best young.

Describe the solution you'd like Add a new column into the overview table

Additional context Keep the same color for cells as "Rate my academy"

[mastertnt]

If you want, I can try to develop it :)

[wsbrenk]

you're welcome to help improving the HO. How do you want to get these numbers. Download from https://www.rate-my.academy/players or do you know the formula?

[mastertnt]

The formula is available, i made a first implementation this afternoon :

[mastertnt]

Ok so the process is to rease a PR ? and how can i set the value for english and french for the column header ? I need an account on PO ?

[wsbrenk]

PR is the correct way.

Concerning translation, you have to introduce the property in src/main/resources/sprache/english.properties (or ...language/english.properties, when @sgcr pull request is merged).

Currently the integration with poeditor is a little bit broken - so the property file has to be imported to poeditor by hand. And there is currently another issure #2116. So i'm really thinking about removing the HO poeditor project and maintain the properties again in our repo.

[mastertnt]

Ok thanks, i will do it.

Last question, before PR, the skills are updated accordingly to a strategy, so the real values from HO are lost (e.g max keeper level). Does it make sense to lose those values ? I understand the strategy but in my point of view, those values must be computed from DB sources not injected as "real" values.

[wsbrenk]

Currently the skill levels (numbers without precisions) for start, current and maximum are downloaded values from HT and should not be changed.

Current and start skill values can be adjusted by the user within the ranges allowed by the downloaded ranges. Overall skill rule is also respected.

If your algorithm will set these values initially, it would be a great help. User changes should be possible to overwrite your settings.

[mastertnt]

No, what i said the values are updated by the previous approach (in the methods : setPlayerMaxSkills and areKeeperSkills). If the player is considered as goalkeeper, the max values are changed. It seems curious to me.

[wsbrenk]

    /**
     * If player is a GoalKeeper, maximum skills of winger, playmaking, passing and scoring are set (4)
     * otherwise the maximum of the keeper skill is set to 4 (field player)
     *
     * @param isKeeper true, keeper maximums are set
     *                 false, field player maximum is set
     */
    public void setPlayerMaxSkills(boolean isKeeper)

Ah, you're talking about this!? But this is the rule in hattrick as far as I know.

[wsbrenk]

Now i see your point - setting the maximum to the value of 4 is of course not the real maximum, which could be lower than 4. If this real limit will be mentioned by the trainer, this lower value should be set (Hopefully). If you want, you can implement another attribute for this "preliminary" maximum value (which does not need to be stored, but recalculated each time the player values are loaded. in the player overview those limited skills should be tagged as bad (red) skills.

[mastertnt]

Ok il will do it like that, thx.

[mastertnt]

    /**
     * If player is a GoalKeeper, maximum skills of winger, playmaking, passing and scoring are set (4)
     * otherwise the maximum of the keeper skill is set to 4 (field player)
     *
     * @param isKeeper true, keeper maximums are set
     *                 false, field player maximum is set
     */
    public void setPlayerMaxSkills(boolean isKeeper)

Ah, you're talking about this!? But this is the rule in hattrick as far as I know.

Yes