search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
193 stars 79 forks source link

[FEATURE]: #2140: Add ArenaInfoPanel #2141

Closed sgcr closed 1 month ago

sgcr commented 2 months ago

  1. changes proposed in this pull request:

    • fixes issue #2140

  2. src/main/resources/release_notes.md ...

    • [x] has been updated

  3. [Optional] suggested person to review this PR @___

sgcr commented 2 months ago

For me it is fine now - I don't want to decide about lombok or not...

Good :)

See also my comment regarding Java records with the last commit.

The pull requests: #2145 and #2143 should be reviewed and merged first because they are partly included here but separate general things.

I would like to rebase this PR here then.

2145 is clearly a bug.

2143 seems to be good idea due to testing.

tychobrailleur commented 2 months ago

I would like to rebase this PR here then. #2145 is clearly a bug. #2143 seems to be good idea due to testing.

Makes sense!

I had a quick glance at it this morning, at a high level, this looks like a good change, I just need to do the full code review this weekend.

sgcr commented 1 month ago

Can be merged.