ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
194 stars 79 forks source link

[BUG] #2139: Fix wrong translation for Spanish for 'worstOfSeason' #2142

Closed sgcr closed 2 months ago

sgcr commented 3 months ago
  1. changes proposed in this pull request:

    • fixes issue #2139
  2. src/main/resources/release_notes.md ...

    • [x] has been updated
  3. [Optional] suggested person to review this PR @wsbrenk I've made the changes also in POEditor...

tychobrailleur commented 2 months ago

If you've made the change to POEditor, would you mind reverting the change to the properties file in the code file (but keep the release note entry)? Just to avoid potential conflicts in the future. Thanks!

tychobrailleur commented 2 months ago

If you've made the change to POEditor, would you mind reverting the change to the properties file in the codebase (but keep the release note entry)? Just to avoid potential conflicts in the future. Thanks!

sgcr commented 2 months ago

poeditor integration is working again - so all translations should be done in poeditor now

New terms of the english properties file will be uploaded automatically to poeditor.

I would suggest to close this pr.

Only release_notes.md is updated. Can be merged.