Describe the bug
I previously tested the subskill calculation and subskill recalculation (7 weeks) and you fixed some minor flaws that I encountered. The current calculation options are working properly. So thank you for that! After doing some tests in the background there is still one occassion in which the subskill calculation is giving different results. I will try to explain.
HO behaviour on regular downloads
When downloading the HRF files every week HO calculates the increase in skill. Sometimes with younger player (mainly below age 25) also after a skill up there is also some extra training. I had a player age 23 that gain a level on passing going from passable (6) to good (7). Since this player was something like 6,86 before leveling up HO also takes into consideration that the level is higher then 7. That is why the skill is shown as 7,13 in passing instead of 7,00 directly after the skill up. I think this is good!
Subskill recalculation
When doing the subskill recalculation in either form. The 0,13 additional training is gone or at least not visible and the skill is shown as 7,00. This means that the training progress is underestimated. I however only see this when the skill up of the player is in the last download.
Suggestions
So could you check in the code if:
a) it has to do with the visual representation of the skill level?
b) the background calculation is done differently for players with a skill up in the latest download when doing a recalculation? maybe there is code that handles this differently and rounds the background value to 0.
extra note
It seems players that didn't have the skill up in the latest download are uneffected, so that makes it a bit strange. So I think that by accident the background value only in those situations is cut off to natural numbers. And it has lasting effects, because the next download will build on that value. So I think that it effects the background calculation.
Describe the bug I previously tested the subskill calculation and subskill recalculation (7 weeks) and you fixed some minor flaws that I encountered. The current calculation options are working properly. So thank you for that! After doing some tests in the background there is still one occassion in which the subskill calculation is giving different results. I will try to explain.
HO behaviour on regular downloads When downloading the HRF files every week HO calculates the increase in skill. Sometimes with younger player (mainly below age 25) also after a skill up there is also some extra training. I had a player age 23 that gain a level on passing going from passable (6) to good (7). Since this player was something like 6,86 before leveling up HO also takes into consideration that the level is higher then 7. That is why the skill is shown as 7,13 in passing instead of 7,00 directly after the skill up. I think this is good!
Subskill recalculation When doing the subskill recalculation in either form. The 0,13 additional training is gone or at least not visible and the skill is shown as 7,00. This means that the training progress is underestimated. I however only see this when the skill up of the player is in the last download.
Suggestions So could you check in the code if: a) it has to do with the visual representation of the skill level? b) the background calculation is done differently for players with a skill up in the latest download when doing a recalculation? maybe there is code that handles this differently and rounds the background value to 0.
extra note It seems players that didn't have the skill up in the latest download are uneffected, so that makes it a bit strange. So I think that by accident the background value only in those situations is cut off to natural numbers. And it has lasting effects, because the next download will build on that value. So I think that it effects the background calculation.
Platform information: