search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
193 stars 79 forks source link

Porting ho table model to kotlin #2177

Open wsbrenk opened 2 weeks ago

wsbrenk commented 2 weeks ago

  1. changes proposed in this pull request:

    • fixes issue #___
    • if not fixing an existing issue, comments explaining the purpose of the PR should be provided)

My first steps in kotlin programming. I'm really excited if this can lead to us being able to support Android in the near future (HO10 or HO11 !?). I don't think it's so great that we lose the history of the changes on this tour.

  1. src/main/resources/release_notes.md ...

    • [ ] has been updated
    • [ ] does not require update

  2. [Optional] suggested person to review this PR @tychobrailleur

tychobrailleur commented 2 weeks ago

I don't think it's so great that we lose the history of the changes on this tour.

I experimented with this a bit, and one way of approaching this is to git mv from java to kt in one commit, and then the next commit converts the content to Kotlin. I don't recommend it, though, because (a) on certain commits we will have broken builds, and (b) after the conversion, the git history will probably be garbage anyway.

tychobrailleur commented 2 weeks ago

I'll have a look when I get a chance, there is a lot to unpack here :)