search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
195 stars 79 forks source link

[eFEAT] Players played or will play in week have a mark #231

Closed mistermax80 closed 5 years ago

mistermax80 commented 5 years ago

Please refer to #44, https://github.com/akasolace/HO/issues/44#issuecomment-490609294

image Following the previous implements, the idea is mark the player in different color if their played or will play a week end match or in week match (Hattrick does this). Futhermore, in tooltip, we can show the minutes played or the estimated minutes.

akasolace commented 5 years ago

@mistermax80 I think this is a duplicate of #125 (follow up of what @yaute74 did on the training view enhancement). If you have something else in mind could you please clarify, otherwise I will let you close that issue.

mistermax80 commented 5 years ago

@akasolace ok, it is can see as enhancement respect to #125. The idea can be to show an icon in player, this icon can be a matcht leageue, or other match, and obscured if the match doesn't played.

akasolace commented 5 years ago

@mistermax80 currently with the color there are 4 information given: partial/full and past/upcoming The icon things could be nice but from what I understand we will only have the info about past/upcoming (we will loose the partial/full). Right ?

mistermax80 commented 5 years ago

Yes correct you said.

yaute74 commented 5 years ago

I think we can close because of #125

mistermax80 commented 5 years ago

Yes, we can close this, but I woulk like insert the match information (league or train match) with icon or test. What do you think?

akasolace commented 5 years ago

Yes, we can close this, but I woulk like insert the match information (league or train match) with icon or test. What do you think?

Frankly, I am not sure that will be nice. Once stamina training is tracked, we can get between 22 and 28 trained players: 28 icons will be IMO very messy and much less informative than a cler color code.

mistermax80 commented 5 years ago

ok, i share your opinion

akasolace commented 5 years ago

ok I close that one then ...