[eBUG] Regression in Prediction Manager for players with specialty "support"

[zerebart]

Describe the bug A clear and concise description of what the bug is. https://image.noelshack.com/fichiers/2019/42/5/1571385242-bugerror8.jpg HO v2.0 1374 this morning error message during download of team data. No possibility to access HO after this error

Before today and since september I had no bug at this step (no change on my PC too : java platform 8.0.1720.11 10/05/2018 09:40).

What I've done? ...

=> Trying another time ... same error => Donwload of version 1382 => installation => downloading datas : another error 8

BUT at this step I can close the error message and THEN access HO interface : everything seems to work properly and I can see the 3 downolads I have made this morning

I hope I'm not the only one in such case so that I'm not only an "exception error"

[akasolace]

@zerebart have you always been on DEV channel or did you just give it a try after experiencing the bug? If I understand correctly, now you always have that error on download, but HO still seems to work normally afterward? Do you have a backup of your database made prior to today error ?

[zerebart]

The bug I report here ls the FIRST bug I encounter with HO2.0 v1374 since I installed it in september.

I'm not accustomed with github and I dont understand why I could (should) have been on what you call DEV Channel

Finally, no, I didn't make any back up of my DB since mid of september.

[akasolace]

I'm not accustomed with github and I dont understand why I could (should) have been on what you call DEV Channel

DEV channel is in HO preference (if you downloaded HO 1.437, by default you were on STABLE channel, it means you have not been notified of updates since).

can you send me a copy (as a zip) of your db folder ? (you can drop the zip as attachment here directly in github or you can send it to me via Firefox Send. I will need it to replicate the bug you are experiencing.

Finally, no, I didn't make any back up of my DB since mid of september. Hopefully they are still some backup inside the db folder (they are made automatically)

[zerebart]

db-zerebart.zip

Here is the db

[akasolace]

@zerebart it says your zip file is invalid. I can't open it. Can you try again please

[zerebart]

i send it another time db-zerebart.zip

[akasolace]

@zerebart ok thank you. This week I won't have time but I will have a look next week. For my info, do you still have the same behaviour?

[akasolace]

@mistermax80 @DavidatorusF can one of you open this archive? it appears as invalid to me .... thank you

[mistermax80]

@akasolace, I'm able to open by my smartphone... And I see the content.

[DavidatorusF]

@akasolace look on slack

[akasolace]

@pierpaolocira @yaute74 @mistermax80 if one of you has time to look at this one in the coming days please do. Otherwise I will do it in the week of 4th of November. At this stage I am not even sure we really have an issue here hence it might not worth to block 2.0 release for this ....

[yaute74]

@akasolace I have a look, it's a real problem. Must be corrected before the release of the 2.0. We have it when we have a player with speciality 'support' We have 7 different speciality but 'support' speciality has id 8 and array are created with a size of 7!

[akasolace]

thank you @yaute74 ! @zerebart I will release new built Sunday or Monday evening @DavidatorusF can you please amend the release note accordingly !

[akasolace]

closed by da1f294d66d76dccb927f5acdd5009824a820e47

[DavidatorusF]

@yaute74 can you explain me what was the mistake with support player ?

I though this one was already solved...

@akasolace whatever, I added it to release note

[yaute74]

@DavidatorusF it's because the function is not the same in 1.437 I will try to buy a support player ...

[akasolace]

@yaute74 can you explain me what was the mistake with support player ? I though this one was already solved...

I looked at the commit made by @yaute74. I think that in 1.435 we close one bug that was making impossible for a user to download data if they had a support player. Here @yaute74 went further and change other part of the code that raised issue if player with suport specialty was put in the lineup.

I would say for the release note we can add something generic like "close additional issues related to player with support specialty"

We will also need to confirm this time all works well for such player. I will also look around for such a player which would allow me to do in depth check.

[yaute74]

@akasolace it's because in b663a32f7f387c6f6d89e58394725895411dd83e we remove

if (specialty < SPEC_NONE || specialty >= SPEC_ALL)
    specialty = SPEC_NONE;

[akasolace]

@yaute74 ok thank you. Not sure why I removed that at the time ...

@DavidatorusF so in the end no need to mention that in the release note (sorry for the confusion), it was a regression I introduced while working on prediction rating

[zerebart]

Thanks for all your job! Suprisingly (to me... I didn't change anything since last friday when I got 1.438 version) I didn't have any error today

[yaute74]

@zerebart maybe you change your lineup on hattrick and remove your 'support' player

[zerebart]

Possible (if the problem is the support "player" then my bug was because I prepared my team for satursday's friendly and there was my support player in it).

Hope you will make a great job for this 2.0 version (from now on I encounter also some presentation's unpleasantnesses, sepcially in the lineup tab)