search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
195 stars 79 forks source link

[eFEAT] Player Details: use new info available via CHPP #287

Closed akasolace closed 2 years ago

akasolace commented 4 years ago

Add the following information in Player details

mistermax80 commented 4 years ago

@akasolace it can be nice to show the player avatar in HO, there is an CHPP in order to download the players avatar.

akasolace commented 4 years ago

@mistermax80 I did not know it was available. I am ok or this but not sure where to put it in the GUI, just in player details then, right ?

mistermax80 commented 4 years ago

And the misc tab, and (maybe) in lineup. In addition we can think to create mini avatar in order to insert in the tables, but we should see which is the effect....

DavidatorusF commented 4 years ago

do you know HT-History ? https://www.hattrick.org/goto.ashx?path=%2FCommunity%2FCHPP%2FChppProgramDetails.aspx%3FApplicationId%3D4470

nice to see this post [post=17230405.2] for the installation on windaube

manuhell is now out of Hattrick...

may be nice to have something similar...

akasolace commented 4 years ago

it can be nice to show the player avatar in HO, there is an CHPP in order to download the players avatar.

@mistermax80 I just had a look and it does not look easy, it is required to fetch all components, layery by layers and reconstitute the image. I am sure it can be done but I doubt it worth the effort

akasolace commented 4 years ago

Arrival date => already in HO Owner notes => HO has own player notes, should we change it and only shows from HT or keep it as is Matches for current team => we can add this Goals for current team => we can add this

@mistermax80 @DavidatorusF @yaute74 what do you think ? Is there anything here that can be an improvement ? Shoud we close this ticket and leave this untouched ?

yaute74 commented 4 years ago

For me Matches and Goals could be interesting but not a priority

akasolace commented 4 years ago

ok, I move the milestone

mistermax80 commented 4 years ago

OK for me, but the notes in HT are for only supporter, so we can think if the user is supporter the player note content in HO is the same in HT, for not supporter users the note are only in HO. Other additional information can be: the number of injuries, marks (for current season and always), but I don't know if this information are available by CHPP.

wsbrenk commented 4 years ago

why should we limit ourselves here to the chpp features. @akasolace has just evaluated the special events in the matches. Why don't we want to evaluate them statistically (total, per player, per season ...)

akasolace commented 4 years ago

@akasolace has just evaluated the special events in the matches. Why don't we want to evaluate them statistically (total, per player, per season ...)

@wsbrenk you mean evalute the special events statistically ? Is it not the role of the currently broken special events module (see steps 2 and 3 of https://github.com/akasolace/HO/issues/309#issuecomment-570135381)