[eBUG] MatchesOverview NPE

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager

https://ho-dev.github.io/HattrickOrganizer/

GNU Lesser General Public License v3.0

195 stars 79 forks source link

[eBUG] MatchesOverview NPE #396

Closed wsbrenk closed 4 years ago

wsbrenk commented 4 years ago

[x] map remaining MachEvent

From the HO Forum:

Hello

When I try to open 'Matches' tab HO 2.1 returns an error 'java.lang.NullPointerException'. I works on Ubuntu 18.04.4 LTS and have Java in the latest version. matcherOverview

masher82 commented 4 years ago

Again I have taken the latest build from https://github.com/akasolace/HO/releases/tag/2.2 which seems to be 2.2.0.2642 and I still get the NPE when opening the games tab.

netmaniac commented 4 years ago

Same here. I can share with You whole ~/.ho folder. This is just a game :) Maybe with data You can get it sorted faster. I wish I could help anything more, but java is not my world :)

akasolace commented 4 years ago

@netmaniac yes please share your database, it might makes things easier @wsbrenk so apparently still something else ....

masher82 commented 4 years ago

Checked out the code and had a short look at the issue:

apparently the resultset in line 164 is null
the resultset is null because the exception "java.sql.SQLSyntaxErrorException: user lacks privilege or object not found: MATCH_EVENT_ID" is thrown when executing the query. The catch clause then returns null so you should check for null and handle it appropriately.
even a simple "select * from MATCHHIGHLIGHTS;" executed against the HO database by using HSQLDBs built-in client throws a similar exception for the MATCHHIGHLIGHTS table.

So there seems to be a general issue with the database. Will investigate further when I when I have some time

netmaniac commented 4 years ago

@akasolace I have sent download link via email

wsbrenk commented 4 years ago

@netmaniac @masher82 how did you test the new version? if you did NOT delete the old corrupt database, it could not work. you either have to delete the database folder and start from scratch or you have to change the DBVersion value to 25 in your old database to run an update of the database table.

wsbrenk commented 4 years ago

or i have to deliver another patch that increments the DBVersion to 27 and runs the updates of MATCHHIGHLIGHTS again.

netmaniac commented 4 years ago

@wsbrenk I didnt think about this. Now I have removed ~/.ho and started again. Now it works. :)

wsbrenk commented 4 years ago

@netmaniac great - thanks for the information.

wsbrenk commented 4 years ago

@akasolace the next pull request handles db update to intermediate version 27, which fixes the database table

akasolace commented 4 years ago

hopefully this time it is closed by edde7a2631e0713a1b717c8a3ee80851f9c9087c :-)

akasolace commented 4 years ago

@masher82 @netmaniac @wsbrenk can you please check the error has been fixed in HO_2.2.0.2644 thank you

wsbrenk commented 4 years ago

@akasolace the test i did was to install an old HO2.1 version (2.1.0.2495). with that version i initialized a new database. the matchhighlightstable was corrupt (event_index, injury, and match_event_id were missing). then i updated ho with the new dev version (2.2.0.2644). the result was a fixed table with correct columns.