search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
195 stars 78 forks source link

[BUG] missing weather and weather forecast for htointegrated game #832

Open akasolace opened 3 years ago

akasolace commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots If applicable, add screenshots to help explain your problem.

Platform information:

Additional context Add any other context about the problem here.

akasolace commented 3 years ago

@wsbrenk I reopened this ticket as I can see it again today. Wheather information are correct for my upcoming league game but null for my upcoming division tournament game. You have been the one developing that part maybe you can have a look ...

wsbrenk commented 3 years ago

@akasolace i'm no longer a friend of division battles, so i can not reproduce this issue.

looking at OnlineWorker.downloadMatchData, i found my comment from last year saying that in division battle match details the arena id is set to 0. if that is still the case, there is no chance to retrieve weather infos, i think. could you try to verify this?

XMLMatchdetailsParser.readArena should init arena id.

akasolace commented 3 years ago

yes this is the issue I guess:

<?xml version="1.0" encoding="utf-8"?>
<HattrickData>
  <FileName>matchdetails.xml</FileName>
  <Version>3.0</Version>
  <UserID>13441219</UserID>
  <FetchedDate>2021-02-03 20:45:03</FetchedDate>
  <UserSupporterTier>diamond</UserSupporterTier>
  <SourceSystem>HTOIntegrated</SourceSystem>
  <Match>
    <MatchID>21071851</MatchID>
    <MatchType>50</MatchType>
    <MatchContextId>3686824</MatchContextId>
    <MatchRuleId>0</MatchRuleId>
    <CupLevel>0</CupLevel>
    <CupLevelIndex>0</CupLevelIndex>
    <MatchDate>2021-02-05 15:00:00</MatchDate>
    <HomeTeam>
      <HomeTeamID>1754082</HomeTeamID>
      <HomeTeamName>FC_Roblochon</HomeTeamName>
    </HomeTeam>
    <AwayTeam>
      <AwayTeamID>291274</AwayTeamID>
      <AwayTeamName>Houilles Football Club</AwayTeamName>
    </AwayTeam>
    <Arena>
      <ArenaID>0</ArenaID>
      <ArenaName></ArenaName>
    </Arena>
  </Match>
</HattrickData>