search

ho-dev / HattrickOrganizer

Assistant for Hattrick online football manager
https://ho-dev.github.io/HattrickOrganizer/
GNU Lesser General Public License v3.0
195 stars 79 forks source link

[BUG] In Matches, own goals are given to the wrong team #998

Closed dominiquelee closed 3 years ago

dominiquelee commented 3 years ago

Describe the bug In Matches, own goals are not properly reported in the main table image

Here's the match in Hattrick: https://www.hattrick.org/goto.ashx?path=/Club/Matches/Match.aspx?matchID=671245002

To Reproduce In Matches, open a match with an own goal. The score will be correct in the lower side details, but not in the main table.

Platform information:

Additional context In the Chance Distribution, Hattrick themselves give the SE to the team that has the unpredictable player that scores the own goal, so it's already quite bizarre there.

wsbrenk commented 3 years ago

this looks like an unexpected change in hattrick. In the own goal event, which I found in my database (https://www.hattrick.org/goto.ashx?path=/Club/Matches/Match.aspx?matchID=654811668), the right teamId is noted in the event.

wsbrenk commented 3 years ago

this is the info from hattrick: "there is indeed a bug here but not related to chpp, it's also on the website. they will look deeper in it, seems not easy :)"

wsbrenk commented 3 years ago

i'm implementing a verfication which checks if matchdetails values of the end result are equal to the counting of the goals in match events. if not all goals are moved to the last match part (second half, extra time or penalty contest).

wsbrenk commented 3 years ago

info from hattrick: the event 125 has been fixed and old matches too

akasolace commented 3 years ago

so we can close this issue, right ?

wsbrenk commented 3 years ago

@akasolace yes - and even if the hattricks will reintroduce this error, it should be handled by the commits.