ho-nl / magento2-Ho_Templatehints

H&O Magento 2 Advanced Template Hints module
BSD 2-Clause "Simplified" License
269 stars 68 forks source link

Fixed incorrect package name in composer require command #21

Closed royvanos closed 7 years ago

royvanos commented 7 years ago

Fixed an incorrect package name in the composer require command which prevented users from installing the module according to the information in the README.md file.

PascalBrouwers commented 7 years ago

@royvanos thank you for the PR. Actually because of an issue with the Magento Marketplace we are moving to the honl namespace. @paales will update this soon.

philcook commented 7 years ago

Please can we say in the README.md that you are in the process of moving so for now use the dashed version and when the transfer is complete update to the non dashed version. Just as a new user of this project this added confusion and would be good for future users to not endure the same.

paales commented 7 years ago

@philcook I've updated the package on packagist.org and added the replace section to composer.json, everything should be fine now:

"replace": {
    "ho-nl/magento2-templatehints": "self.version"
  },
paales commented 7 years ago

@royvanos Can you confirm that everything is working as expected?

royvanos commented 7 years ago

@paales Yes, it works perfectly fine 👍

philcook commented 7 years ago

@paales works perfectly thanks.

paales commented 7 years ago

Awesome!!